linux-kernel - [PATCH] mm/vmscan: fix error return in kswapd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Apr 2013 19:09:45 +0800
From:	Xishi Qiu <qiuxishi@...wei.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, <hughd@...gle.com>,
	<riel@...hat.com>, <khlebnikov@...nvz.org>
CC:	<linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>,
	Xishi Qiu <qiuxishi@...wei.com>,
	Hanjun Guo <guohanjun@...wei.com>,
	Zhangdianfang <zhangdianfang@...wei.com>
Subject: [PATCH] mm/vmscan: fix error return in kswapd_run()

Fix the error return value in kswapd_run(). The bug was
introduced by commit d5dc0ad928fb9e972001e552597fd0b794863f34
"mm/vmscan: fix error number for failed kthread".

Signed-off-by: Xishi Qiu <qiuxishi@...wei.com>
---
 mm/vmscan.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index 88c5fed..950636e 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -3188,9 +3188,9 @@ int kswapd_run(int nid)
 	if (IS_ERR(pgdat->kswapd)) {
 		/* failure at boot is fatal */
 		BUG_ON(system_state == SYSTEM_BOOTING);
-		pgdat->kswapd = NULL;
 		pr_err("Failed to start kswapd on node %d\n", nid);
 		ret = PTR_ERR(pgdat->kswapd);
+		pgdat->kswapd = NULL;
 	}
 	return ret;
 }
-- 
1.7.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/