linux-kernel - Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove POOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130402022431.GA6255@htj.dyndns.org>
Date:	Mon, 1 Apr 2013 19:24:31 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2 tj/for-3.10] workqueue: add wq->freezing and remove
 POOL_FREEZING

Hello, Lai.

On Tue, Apr 02, 2013 at 10:17:33AM +0800, Lai Jiangshan wrote:
> ->flags is hot and almost read-only(except __WQ_DRAINING).
> __WQ_DRAINING bit is accessed for every queue_work(), so we add it to hot ->flags.
> 
> __WQ_ORDERED is read-only.
> 
> ->freezing is cold and non-read-only.
> I don't think we need to add __WQ_FREEZING to ->flags.

Hmm... I'm not following.  If you have multiple hot flags which may be
used from different CPUs, yeah, you may want to put them in separate
cachelines but cold flags don't really matter either way so why put it
in a separate field?  Can you please elaborate?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/