linux-kernel - Re: [PATCH v5 5/8] staging: zcache: fix zcache writeback in debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Apr 2013 11:14:31 -0400
From:	Konrad Rzeszutek Wilk <konrad@...nok.org>
To:	Wanpeng Li <liwanp@...ux.vnet.ibm.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>,
	Minchan Kim <minchan@...nel.org>, linux-mm@...ck.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH v5 5/8] staging: zcache: fix zcache writeback in debugfs

On Mon, Apr 1, 2013 at 10:46 PM, Wanpeng Li <liwanp@...ux.vnet.ibm.com> wrote:
> commit 9c0ad59ef ("zcache/debug: Use an array to initialize/use debugfs attributes")
> use an array to initialize/use debugfs attributes, .name = #x, .val = &zcache_##x.
> For zcache writeback, this commit set .name = zcache_outstanding_writeback_pages and
> .name = zcache_writtenback_pages seperately, however, corresponding .val =
> &zcache_zcache_outstanding_writeback_pages and .val = &zcache_zcache_writtenback_pages,
> which are not correct.
>

Weird. I recall spotting that when I did the patches, but I wonder how
I missed this.
Ah, now I remember - I  did a silly patch by adding in #define
CONFIG_ZCACHE_WRITEBACK
in the zcache-main.c code, but forgot to try it out here.

<sigh>

Thank you for spotting and fixing it.

Reviewed-by: Konrad Rzeszutek Wilk <konrad@...nel.org>

> Signed-off-by: Wanpeng Li <liwanp@...ux.vnet.ibm.com>
> ---
>  drivers/staging/zcache/debug.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/zcache/debug.c b/drivers/staging/zcache/debug.c
> index 254dada..d2d1fdf 100644
> --- a/drivers/staging/zcache/debug.c
> +++ b/drivers/staging/zcache/debug.c
> @@ -31,8 +31,8 @@ static struct debug_entry {
>         ATTR(eph_nonactive_puts_ignored),
>         ATTR(pers_nonactive_puts_ignored),
>  #ifdef CONFIG_ZCACHE_WRITEBACK
> -       ATTR(zcache_outstanding_writeback_pages),
> -       ATTR(zcache_writtenback_pages),
> +       ATTR(outstanding_writeback_pages),
> +       ATTR(writtenback_pages),
>  #endif
>  };
>  #undef ATTR
> --
> 1.7.7.6
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/