linux-kernel - Re: [PATCH 20/23] perf: consolidate CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515AF776.3090105@gmail.com>
Date:	Tue, 02 Apr 2013 09:21:26 -0600
From:	David Ahern <dsahern@...il.com>
To:	Paul Bolle <pebolle@...cali.nl>
CC:	acme@...stprotocols.net, linux-kernel@...r.kernel.org,
	Borislav Petkov <bp@...en8.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>, Jiri Olsa <jolsa@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 20/23] perf: consolidate CONFIG_LIBELF checks in Makefile

On 4/2/13 3:37 AM, Paul Bolle wrote:
> On Mon, 2013-04-01 at 21:54 -0600, David Ahern wrote:
>> --- a/tools/perf/Makefile
>> +++ b/tools/perf/Makefile
>> [...]
>> @@ -602,6 +590,16 @@ ifdef CONFIG_LIBELF
>>       endif
>>
>>   else
>> +    ifdef CONFIG_DWARF
>> +        $(error CONFIG_DWARF depends on LIBELF)
>> +    endif
>> +    ifdef CONFIG_DEMANGLE
>> +        $(error CONFIG_DEMANGLE depends on LIBELF)
>> +    endif
>> +    ifdef CONFIG_LIBUNWIND
>> +        $(error CONFIG_LIBUNWIND depends on LIBELF)
>> +    endif
>> +
>>       EXTLIBS := $(filter-out -lelf,$(EXTLIBS))
>>
>>       # Remove ELF/DWARF dependent codes
>
> A quick scan of your series suggests you check here for dependencies
> that are already enforced by the kconfig tools. Why is this needed?

Just a side effect of the evolutionary path from where the perf build is 
today to the kconfig route. Certainly the above (and similar ones) are 
not needed in the end.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/