linux-kernel - Re: [PATCH 3/5] dump_stack: consolidate dump_stack() implementations and unify their behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130402182604.GC6185@htj.dyndns.org>
Date:	Tue, 2 Apr 2013 11:26:04 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Martin Schwidefsky <schwidefsky@...ibm.com>
Cc:	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...hat.com, x86@...nel.org,
	rth@...ddle.net, linux@....linux.org.uk, msalter@...hat.com,
	starvik@...s.com, dhowells@...hat.com, tony.luck@...el.com,
	benh@...nel.crashing.org, takata@...ux-m32r.org,
	geert@...ux-m68k.org, james.hogan@...tec.com, monstr@...str.eu,
	ralf@...ux-mips.org, jonas@...thpole.se, rkuo@...eaurora.org,
	liqin.chen@...plusct.com, davem@...emloft.net, lethal@...ux-sh.org,
	vgupta@...opsys.com, chris@...kel.net, cmetcalf@...era.com,
	ysato@...rs.sourceforge.jp, gxt@...c.pku.edu.cn, jdike@...toit.com,
	linux-s390@...r.kernel.org, Mike Frysinger <vapier@...too.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 3/5] dump_stack: consolidate dump_stack() implementations
 and unify their behaviors

Hello, Martin.

On Tue, Apr 02, 2013 at 08:48:08AM +0200, Martin Schwidefsky wrote:
> > The couple of extra fields aren't worth an s390 version of dump_stack()
> > that differs from all other architectures.
> > Please drop the s390 version as well. Thanks!
> 
> Hmm, we would lose task_thread_info(current)->cpu and current->thread.ksp,
> I don't care much about the kernel stack pointer which has been stored at
> the last call to __switch_to but the cpu number might be interesting.
> Could we add the cpu number to the generic dump_stack version?

Yeah, I can move CPU from show_regs() to dump_stack().  It actually
makes sense.  I'll do that and convert s390 together with other archs.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/