linux-kernel - Re: [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1304021427450.1314-100000@iolanthe.rowland.org>
Date:	Tue, 2 Apr 2013 14:33:36 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Florian Fainelli <florian@...nwrt.org>
cc:	linux-kernel@...r.kernel.org, <arnd@...db.de>,
	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if
 USB_EHCI_HCD block

On Tue, 2 Apr 2013, Florian Fainelli wrote:

> Thist patch removes the depends on USB_EHCI_HCD that the various USB
> EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD
> / endif block. The EHCI HCD platform and Octeon drivers have been moved
> around to remain enclosed within this block.
> 
> Signed-off-by: Florian Fainelli <florian@...nwrt.org>

Okay except for two things.  First, you missed the
USB_EHCI_BIG_ENDIAN_DESC entry.  Second, the Kconfig file has this
right in the middle of the section you changed:

config USB_FSL_MPH_DR_OF
	tristate

It's probably a mistake to put this under the "if USB_EHCI_HCD"
umbrella.  I guess it should be moved out of the way.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/