linux-kernel - Re: [PATCH] drivers/block/drbd: remove erroneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515BE19F.2080709@asianux.com>
Date:	Wed, 03 Apr 2013 16:00:31 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	drbd-dev@...ts.linbit.com
CC:	drbd-user@...ts.linbit.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/block/drbd: remove erroneous semicolon

Hello maintainers:

  when you have time, please help to check this patch whether is OK.

  thanks.

gchen.

On 2013年03月27日 14:56, Chen Gang wrote:
> 
>   need remove it, or always return -EBUSY.
>   it is found by compiler with 'EXTRA_CFLAG=-W'.
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  drivers/block/drbd/drbd_actlog.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/drbd/drbd_actlog.c b/drivers/block/drbd/drbd_actlog.c
> index 6afe173..6608076 100644
> --- a/drivers/block/drbd/drbd_actlog.c
> +++ b/drivers/block/drbd/drbd_actlog.c
> @@ -389,7 +389,7 @@ int drbd_al_begin_io_nonblock(struct drbd_conf *mdev, struct drbd_interval *i)
>  		if (unlikely(tmp != NULL)) {
>  			struct bm_extent  *bm_ext = lc_entry(tmp, struct bm_extent, lce);
>  			if (test_bit(BME_NO_WRITES, &bm_ext->flags)) {
> -				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags));
> +				if (!test_and_set_bit(BME_PRIORITY, &bm_ext->flags))
>  					return -EBUSY;
>  				return -EWOULDBLOCK;
>  			}
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/