linux-kernel - Re: [PATCH 3/9 v2] f2fs: remove redundant lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd9SEhxpqiGRqO_h+EkdqcmJ8Mm_cJtmrmYowmG1700njg@mail.gmail.com>
Date:	Wed, 3 Apr 2013 17:27:51 +0900
From:	Namjae Jeon <linkinjeon@...il.com>
To:	jaegeuk.kim@...sung.com
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [PATCH 3/9 v2] f2fs: remove redundant lock_page calls

2013/4/3, Jaegeuk Kim <jaegeuk.kim@...sung.com>:
Hi. Jaegeuk.
> Hi,
>
> Agreed, and send v2.
>
> Change log from v1:
>  o remain read_node_page and remove the lock part
>
> From 04006aecac2882c574fe8a7de926bc52c73a8ad1 Mon Sep 17 00:00:00 2001
> From: Jaegeuk Kim <jaegeuk.kim@...sung.com>
> Date: Sun, 31 Mar 2013 12:47:20 +0900
> Subject: [PATCH] f2fs: remove redundant lock_page calls
> Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
> linux-f2fs-devel@...ts.sourceforge.net
>
> In get_node_page, we do not need to call lock_page all the time.
>
> If the node page is cached as uptodate,
>
> 1. grab_cache_page locks the page,
> 2. read_node_page unlocks the page, and
> 3. lock_page is called for further process.
>
> Let's avoid this.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk.kim@...sung.com>
Yes, Looks good!
Reviewed-by: Namjae Jeon <namjae.jeon@...sung.com>

Thanks.
> ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/