linux-kernel - RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <24b501ce3011$454d3c70$cfe7b550$%kim@samsung.com>
Date:	Wed, 03 Apr 2013 11:16:37 +0900
From:	Kukjin Kim <kgene.kim@...sung.com>
To:	'Kukjin Kim' <kgene.kim@...sung.com>,
	'Doug Anderson' <dianders@...omium.org>
Cc:	'Jongpill Lee' <boyko.lee@...sung.com>,
	'Jaecheol Lee' <jc.lee@...sung.com>,
	'Thomas Abraham' <thomas.ab@...sung.com>,
	'Olof Johansson' <olof@...om.net>,
	'Jonathan Kliegman' <kliegs@...omium.org>,
	'Michael Spang' <spang@...omium.org>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Russell King' <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: RE: [PATCH 0/2] These two patches to s3c_pm_arch_prepare_irqs() were
 part of the work

Kukjin Kim wrote:
> 
> Doug Anderson wrote:
> >
> > to make suspend/resume reliable on the ARM Chromebook
> > (exynos5250-snow).
> >
> > A few more details:
> > - The first patch is not strictly needed but was a nice cleanup.  Our
> >   understanding was that EINT0 was originally turned on for exynos
> >   evt0 silicon and not needed for evt1.
> 
> Looks good to me, applied, thanks.
> 
> > - The second patch is more important and (also) more obvious.  The
> >   function was modifying the S5P_WAKEUP_MASK register and then
> >   clobbering its own modifications.
> >
> Applied with 1st one, BTW, do you want to send this for stable tree?
> 
One more note, just now I discussed Jaecheol Lee about the bit,
ENABLE_WAKEUP_SW, as the patch fixed, it should be cleared but used to be
set s3c_irqwake_intmask. Let me check again, then if any updates I'll let
you know.

Thanks.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/