linux-kernel - Re: [PATCH] clocksource: mxs_timer: Add semicolon at end of line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130403022939.GL24039@S2101-09.ap.freescale.net>
Date:	Wed, 3 Apr 2013 10:29:40 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Fabio Estevam <fabio.estevam@...escale.com>
CC:	<tglx@...utronix.de>, <john.stultz@...aro.org>,
	<linux-kernel@...r.kernel.org>, <festevam@...il.com>
Subject: Re: [PATCH] clocksource: mxs_timer: Add semicolon at end of line

On Tue, Apr 02, 2013 at 01:30:32PM -0300, Fabio Estevam wrote:
> Fix the following build error:
> 
> drivers/clocksource/mxs_timer.c:304:1: error: expected ',' or ';' at end of input
> 
What's your gcc version?  I'm using gcc version 4.6.3 (Ubuntu/Linaro
4.6.3-1ubuntu5), and do not see the compile error.

Anyway, patch applied.

> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
>  drivers/clocksource/mxs_timer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clocksource/mxs_timer.c b/drivers/clocksource/mxs_timer.c
> index a4d469b..02af420 100644
> --- a/drivers/clocksource/mxs_timer.c
> +++ b/drivers/clocksource/mxs_timer.c
> @@ -301,4 +301,4 @@ static void __init mxs_timer_init(struct device_node *np)
>  	irq = irq_of_parse_and_map(np, 0);
>  	setup_irq(irq, &mxs_timer_irq);
>  }
> -CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init)
> +CLOCKSOURCE_OF_DECLARE(mxs, "fsl,timrot", mxs_timer_init);

I guess I took the bad example from drivers/clocksource/vt8500_timer.c.

Shawn

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/