linux-kernel - Re: [PATCH 2/3] usb: phy: twl4030-usb: check regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365001967.3294.4.camel@X230>
Date:	Wed, 03 Apr 2013 18:12:47 +0300
From:	Kalle Jokiniemi <kalle.jokiniemi@...lamobile.com>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Felipe Balbi <balbi@...com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/3] usb: phy: twl4030-usb: check regulator_enable
 return value

On Wed, 2013-04-03 at 16:02 +0200, Fabio Baltieri wrote:
> Since regulator_enable() is going to be marked as __must_check in the
> next merge window, always check regulator_enable() return value and
> print a warning if it fails.

Could go bananas with this and all kinds of recovery schemes, but nah..
Looks good to me. FWIW,

Reviewed-by: Kalle Jokiniemi <kalle.jokiniemi@...lamobile.com>



> 
> Cc: Kalle Jokiniemi <kalle.jokiniemi@...lamobile.com>
> Signed-off-by: Fabio Baltieri <fabio.baltieri@...aro.org>
> ---
>  drivers/usb/phy/phy-twl4030-usb.c | 18 +++++++++++++++---
>  1 file changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/phy/phy-twl4030-usb.c b/drivers/usb/phy/phy-twl4030-usb.c
> index 3f9858f..13e17ae 100644
> --- a/drivers/usb/phy/phy-twl4030-usb.c
> +++ b/drivers/usb/phy/phy-twl4030-usb.c
> @@ -384,9 +384,17 @@ static void __twl4030_phy_power(struct twl4030_usb *twl, int on)
>  
>  static void twl4030_phy_power(struct twl4030_usb *twl, int on)
>  {
> +	int ret;
> +
>  	if (on) {
> -		regulator_enable(twl->usb3v1);
> -		regulator_enable(twl->usb1v8);
> +		ret = regulator_enable(twl->usb3v1);
> +		if (ret)
> +			dev_err(twl->dev, "Failed to enable usb3v1\n");
> +
> +		ret = regulator_enable(twl->usb1v8);
> +		if (ret)
> +			dev_err(twl->dev, "Failed to enable usb1v8\n");
> +
>  		/*
>  		 * Disabling usb3v1 regulator (= writing 0 to VUSB3V1_DEV_GRP
>  		 * in twl4030) resets the VUSB_DEDICATED2 register. This reset
> @@ -395,7 +403,11 @@ static void twl4030_phy_power(struct twl4030_usb *twl, int on)
>  		 * is re-activated. This ensures that VUSB3V1 is really active.
>  		 */
>  		twl_i2c_write_u8(TWL_MODULE_PM_RECEIVER, 0, VUSB_DEDICATED2);
> -		regulator_enable(twl->usb1v5);
> +
> +		ret = regulator_enable(twl->usb1v5);
> +		if (ret)
> +			dev_err(twl->dev, "Failed to enable usb1v5\n");
> +
>  		__twl4030_phy_power(twl, 1);
>  		twl4030_usb_write(twl, PHY_CLK_CTRL,
>  				  twl4030_usb_read(twl, PHY_CLK_CTRL) |


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/