linux-kernel - Re: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <515C8484.507@wwwdotorg.org>
Date:	Wed, 03 Apr 2013 13:35:32 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
CC:	gregkh@...uxfoundation.org, balbi@...com,
	stern@...land.harvard.edu, linux-tegra@...r.kernel.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/7] usb: phy: tegra: Add error handling & clean up.

On 04/03/2013 02:41 AM, Venu Byravarasu wrote:
> Check return values from all GPIO APIs and handle errors accordingly.
> Remove clk_disable_unprepare which is no more needed.

checkpatch fails:

> WARNING: line over 80 characters
> #27: FILE: drivers/usb/phy/phy-tegra-usb.c:547:
> +		dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
> 
> WARNING: line over 80 characters
> #34: FILE: drivers/usb/phy/phy-tegra-usb.c:553:
> +		dev_err(phy->dev, "gpio %d direction not set\n", phy->reset_gpio);
> 
> total: 0 errors, 2 warnings, 72 lines checked
> 
> 0006-usb-phy-tegra-Add-error-handling-clean-up.patch has style problems, please review.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/