linux-kernel - Re: [PATCH] block: avoid using uninitialized value in from queue_var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130403195226.GC4667@kernel.dk>
Date:	Wed, 3 Apr 2013 21:52:26 +0200
From:	Jens Axboe <jaxboe@...ionio.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: avoid using uninitialized value in from
 queue_var_store

On Wed, Apr 03 2013, Arnd Bergmann wrote:
> As found by gcc-4.8, the QUEUE_SYSFS_BIT_FNS macro creates functions
> that use a value generated by queue_var_store independent of whether
> that value was set or not.
> 
> block/blk-sysfs.c: In function 'queue_store_nonrot':
> block/blk-sysfs.c:244:385: warning: 'val' may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Unlike most other such warnings, this one is not a false positive,
> writing any non-number string into the sysfs files indeed has
> an undefined result, rather than returning an error.

Huh indeed, thanks Arnd. Queued up.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/