linux-kernel - RE: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B256D81BAE5131468A838E5D7A24364150E8CC7B@penmbx01>
Date:	Wed, 3 Apr 2013 05:09:53 +0000
From:	"Yang, Wenyou" <Wenyou.Yang@...el.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"richard.genoud@...il.com" <richard.genoud@...il.com>,
	"plagnioj@...osoft.com" <plagnioj@...osoft.com>,
	"Ferre, Nicolas" <Nicolas.FERRE@...el.com>,
	"Lin, JM" <JM.Lin@...el.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for
 lock operations

Hi, Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
> Sent: 2013年4月1日 21:46
> To: Yang, Wenyou
> Cc: linux-arm-kernel@...ts.infradead.org; grant.likely@...retlab.ca;
> richard.genoud@...il.com; plagnioj@...osoft.com; Ferre, Nicolas; Lin, JM;
> spi-devel-general@...ts.sourceforge.net; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v7 06/14] spi/spi-atmel: add flag to controller data for lock
> operations
> 
> On Tue, Mar 19, 2013 at 03:46:03PM +0800, Wenyou Yang wrote:
> 
> > +static void atmel_spi_lock(struct atmel_spi *as) {
> > +		spin_lock_irqsave(&as->lock, as->flags); }
> 
> Coding style.
I will change it in next version.

> 
> > -	spin_unlock(&as->lock);
> > +	atmel_spi_unlock(as);
> >  	msg->complete(msg->context);
> > -	spin_lock(&as->lock);
> > +	atmel_spi_lock(as);
> 
> This replaces non-irqsave versions with irqsave versions of the lock.
> Is this safe/correct?  If it is I'd have expected some sort of mention of it in the
> commit log.
I will add some commit log.

Best Regards,
Wenyou Yang