linux-kernel - Re: [PATCH 3/7] dump_stack: consolidate dump_stack() implementations and unify their behaviors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Apr 2013 09:13:09 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...hat.com, x86@...nel.org,
	rth@...ddle.net, linux@....linux.org.uk, msalter@...hat.com,
	starvik@...s.com, dhowells@...hat.com, tony.luck@...el.com,
	benh@...nel.crashing.org, takata@...ux-m32r.org,
	geert@...ux-m68k.org, james.hogan@...tec.com, monstr@...str.eu,
	ralf@...ux-mips.org, jonas@...thpole.se, rkuo@...eaurora.org,
	liqin.chen@...plusct.com, davem@...emloft.net, lethal@...ux-sh.org,
	vgupta@...opsys.com, chris@...kel.net, cmetcalf@...era.com,
	ysato@...rs.sourceforge.jp, gxt@...c.pku.edu.cn, jdike@...toit.com,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux-s390@...r.kernel.org, Mike Frysinger <vapier@...too.org>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Fengguang Wu <fengguang.wu@...el.com>
Subject: Re: [PATCH 3/7] dump_stack: consolidate dump_stack()
 implementations and unify their behaviors

On Wed,  3 Apr 2013 12:14:53 -0700
Tejun Heo <tj@...nel.org> wrote:

> v2: CPU number added to the generic debug info as requested by s390
>     folks and dropped the s390 specific dump_stack().  This loses %ksp
>     from the debug message which the maintainers think isn't important
>     enough to keep the s390-specific dump_stack() implementation.
> 
>     dump_stack_print_info() is moved to kernel/printk.c from
>     lib/dump_stack.c.  Because linkage is per objecct file,
>     dump_stack_print_info() living in the same lib file as generic
>     dump_stack() means that archs which implement custom dump_stack()
>     - at this point, only blackfin - can't use dump_stack_print_info()
>     as that will bring in the generic version of dump_stack() too.  v1
>     The v1 patch broke build on blackfin due to this issue.  The build
>     breakage was reported by Fengguang Wu.

For the s390 changes:
Acked-by: Martin Schwidefsky <schwidefsky@...ibm.com>

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/