linux-kernel - Re: [PATCH v3.7+] HID: magicmouse: fix race between input

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Apr 2013 09:51:17 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3.7+] HID: magicmouse: fix race between input_register()
 and probe()

On Tue, 2 Apr 2013, Benjamin Tissoires wrote:

> Since kernel 3.7, it appears that the input registration occured before
> the end of magicmouse_setup_input(). This is shown by receiving a lot of
> "EV_SYN SYN_REPORT 1" instead of normal "EV_SYN SYN_REPORT 0".
> This value means that the output buffer is full, and the user space
> is loosing events.
> 
> Using .input_configured guarantees that the race is not occuring, and that
> the call of "input_set_events_per_packet(input, 60)" is taken into account
> by input_register().
> 
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=908604
> 
> Reported-and-Tested-By: Clarke Wixon <cwixon@....net>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> ---
> 
> Hi Jiri,
> 
> this one can goes to stable (so 3.8) as well.

Applied, and will push for 3.9 still.

Thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/