[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2013 16:57:02 +0200
From: Oskar Andero <oskar.andero@...ymobile.com>
To: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>
CC: "dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
"Makarov, Aleksej" <Aleksej.Makarov@...ymobile.com>,
Radovan Lekanovic <radovan.lekanovic@...ymobile.com>
Subject: Re: [PATCH] input: don't call input_dev_release_keys() in resume
On 15:01 Thu 07 Mar , oskar.andero@...ymobile.com wrote:
> From: Aleksej Makarov <aleksej.makarov@...ymobile.com>
>
> When waking up the platform by pressing a specific key, sending a
> release on that key makes it impossible to react on the event in
> user-space.
>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Reviewed-by: Radovan Lekanovic <radovan.lekanovic@...ymobile.com>
> Signed-off-by: Aleksej Makarov <aleksej.makarov@...ymobile.com>
> Signed-off-by: Oskar Andero <oskar.andero@...ymobile.com>
> ---
> drivers/input/input.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/input.c b/drivers/input/input.c
> index c044699..61ce19f 100644
> --- a/drivers/input/input.c
> +++ b/drivers/input/input.c
> @@ -1690,7 +1690,10 @@ static int input_dev_resume(struct device *dev)
> {
> struct input_dev *input_dev = to_input_dev(dev);
>
> - input_reset_device(input_dev);
> + mutex_lock(&input_dev->mutex);
> + if (input_dev->users)
> + input_dev_toggle(input_dev, true);
> + mutex_unlock(&input_dev->mutex);
>
> return 0;
> }
> --
> 1.7.8.6
>
Ping. Any input on the patch above?
-Oskar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists