[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Thu, 4 Apr 2013 08:43:51 -0700
From: Tejun Heo <tj@...nel.org>
To: Fengguang Wu <fengguang.wu@...el.com>
Cc: Christopher Li <sparse@...isli.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: kernel/workqueue.c:4434:61: sparse: expression using sizeof bool
Hey,
On Thu, Apr 04, 2013 at 09:42:09AM +0800, Fengguang Wu wrote:
> > > 4433 /* copy worker description */
> > > > 4434 probe_kernel_read(&desc_valid, &worker->desc_valid, sizeof(desc_valid));
> > > 4435 if (desc_valid)
> >
> > I don't know what to make of this warning. Yes, it's probing a bool
> > variable and of course using sizeof(bool) to do that. Why does sparse
> > complain about this?
>
> I guess sparse warns on sizeof(bool) because it is compiler defined.
> It may be 1, 4, or even 8 depending on the gcc version and platform.
Yeah, it's copying out a bool so as long as that's the actual size,
it's okay. I mean, it's not like sizeof(long) is constant across
platforms. I'm gonna ignore it but still curious what the warning is
good for.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists