[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 4 Apr 2013 22:06:35 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Jacob Shin <jacob.shin@....com>
Cc: "Rafael J. Wysocki" <rjw@...k.pl>, cpufreq@...r.kernel.org,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
Thomas Renninger <trenn@...e.de>,
Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH V4 1/2] cpufreq: ondemand: allow custom
powersave_bias_target handler to be registered
On 4 April 2013 21:49, Jacob Shin <jacob.shin@....com> wrote:
> diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c
> +static void od_set_powersave_bias(unsigned int powersave_bias)
> +{
> + unsigned int cpu;
> + struct od_dbs_tuners *od_tuners;
> +
> + if (!have_governor_per_policy()) {
> + od_tuners = od_dbs_cdata.gdbs_data->tuners;
> + od_tuners->powersave_bias = powersave_bias;
> + return;
> + }
> +
> + for_each_online_cpu(cpu) {
> + struct cpufreq_policy *policy;
> + struct dbs_data *dbs_data;
> + policy = per_cpu(od_cpu_dbs_info, cpu).cdbs.cur_policy;
> + dbs_data = policy->governor_data;
> + od_tuners = dbs_data->tuners;
> + od_tuners->powersave_bias = powersave_bias;
> + }
You can keep only the for_each_online_cpu() loop and remove the other
one. And in that one also, you don't have to do this for every cpu...
something like this will help you...
cpus_processed = NULL;
for_each_online_cpu(cpu) {
if cpu-is-present-in cpus_processed
continue;
cpu-set-mask(cpus_processed, policy->cpus);
}
Syntax is poor, please choose the correct one.
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists