linux-kernel - Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Apr 2013 21:02:30 +0300
From:	Felipe Balbi <balbi@...com>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Felipe Balbi <balbi@...com>,
	Thomas Winischhofer <thomas@...ischhofer.net>,
	Florian Fainelli <florian@...nwrt.org>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	<arnd@...db.de>, <gregkh@...uxfoundation.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB
 block

Hi,

On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> > > index 30ea7ca..0d03a52 100644
> > > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > > @@ -1,7 +1,7 @@
> > >  
> > >  config USB_SISUSBVGA
> > >  	tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> > > -	depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> > > +	depends on (USB_MUSB_HDRC || USB_EHCI_HCD)
> > 
> > is it just me or would everybody agree that depending on MUSB or EHCI
> > here is wrong ?
> 
> That line certainly looks like it could be removed entirely.  Perhaps 
> the original author can enlighten us.
> 
> In any case, it's not relevant to the purpose of this patch set.

right :-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)