linux-kernel - Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr in cpio files info array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 4 Apr 2013 11:30:47 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Renninger <trenn@...e.de>,
	Tang Chen <tangchen@...fujitsu.com>,
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 06/20] x86, ACPI: Store override acpi tables phys addr
 in cpio files info array

On Thu, Apr 04, 2013 at 11:27:42AM -0700, Tejun Heo wrote:
> > +		/*
> > +		 * have to use unsigned long, otherwise 32bit spit warning
> > +		 * and it is ok to unsigned long, as bootloader would not
> > +		 * load initrd above 4G for 32bit kernel.
> > +		 */
> > +		unsigned long addr = (unsigned long)acpi_initrd_files[no].data;
> 
> I can't say I like this.  It's stuffing phys_addr_t into void *.  It
> might work okay but the code is a bit misleading / confusing.  "void
> *" shouldn't contain a physical address.  Maybe the alternatives are
> uglier, I don't know.  If you can think of a reasonable way to not do
> this, it would be great.

Also the comment contradicts with what you wrote in the next patch.

  Boot loader could load initrd above max_low_pfn.

Hmmm?

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/