linux-kernel - Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 04 Apr 2013 23:00:57 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Lv Zheng <lv.zheng@...el.com>
Cc:	Paul Bolle <pebolle@...cali.nl>, Len Brown <lenb@...nel.org>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"

On Tuesday, March 26, 2013 02:34:25 PM Rafael J. Wysocki wrote:
> On Tuesday, March 19, 2013 11:41:01 AM Paul Bolle wrote:
> > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro was
> > removed from that header in v3.8, with commit
> > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > acmacros.h divergences."). That commit did not explain why that macro
> > was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can now be removed
> > too, as it is unused.
> 
> Lv, can you please comment here?

Lv, I'm still waiting for your comment regarding the commit mentioned above.

Thanks,
Rafael


> > Signed-off-by: Paul Bolle <pebolle@...cali.nl>
> > ---
> > Eyeball tested.
> > 
> >  drivers/acpi/Kconfig | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> > index 92ed969..006b714 100644
> > --- a/drivers/acpi/Kconfig
> > +++ b/drivers/acpi/Kconfig
> > @@ -298,14 +298,6 @@ config ACPI_DEBUG
> >  	  Documentation/kernel-parameters.txt to control the type and
> >  	  amount of debug output.
> >  
> > -config ACPI_DEBUG_FUNC_TRACE
> > -	bool "Additionally enable ACPI function tracing"
> > -	default n
> > -	depends on ACPI_DEBUG
> > -	help
> > -	  ACPI Debug Statements slow down ACPI processing. Function trace
> > -	  is about half of the penalty and is rarely useful.
> > -
> >  config ACPI_PCI_SLOT
> >  	bool "PCI slot detection driver"
> >  	depends on SYSFS
> > 
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/