linux-kernel - Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 05 Apr 2013 17:02:57 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Tomi Valkeinen' <tomi.valkeinen@...com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-fbdev@...r.kernel.org, FlorianSchandinat@....de,
	s.trumtrar@...gutronix.de, plagnioj@...osoft.com,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH RESEND] fbmon: use VESA_DMT_VSYNC_HIGH to fix typo

On Friday, April 05, 2013 3:57 PM, Tomi Valkeinen wrote:
> 
> Hi,
> 
> On 2013-03-29 03:40, Jingoo Han wrote:
> > VESA_DMT_VSYNC_HIGH should be used instead of VESA_DMT_HSYNC_HIGH,
> > because FB_SYNC_VERT_HIGH_ACT is related to vsync, not to hsync.
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > Cc: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> > Cc: Tomi Valkeinen <tomi.valkeinen@...com>
> > ---
> >  drivers/video/fbmon.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/video/fbmon.c b/drivers/video/fbmon.c
> > index 94ad0f7..7f67099 100644
> > --- a/drivers/video/fbmon.c
> > +++ b/drivers/video/fbmon.c
> > @@ -1400,7 +1400,7 @@ int fb_videomode_from_videomode(const struct videomode *vm,
> >  	fbmode->vmode = 0;
> >  	if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> >  		fbmode->sync |= FB_SYNC_HOR_HIGH_ACT;
> > -	if (vm->dmt_flags & VESA_DMT_HSYNC_HIGH)
> > +	if (vm->dmt_flags & VESA_DMT_VSYNC_HIGH)
> >  		fbmode->sync |= FB_SYNC_VERT_HIGH_ACT;
> >  	if (vm->data_flags & DISPLAY_FLAGS_INTERLACED)
> >  		fbmode->vmode |= FB_VMODE_INTERLACED;
> 
> I'll apply this to fbdev fixes.

Oh, thank you. :)

Best regards,
Jingoo Han

> 
>  Tomi
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/