linux-kernel - Re: [PATCH] regulator: core: don't require a supply when supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130405095457.GB6597@opensource.wolfsonmicro.com>
Date:	Fri, 5 Apr 2013 10:54:57 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Andrew Bresticker <abrestic@...omium.org>
Cc:	Liam Girdwood <lrg@...com>, linux-kernel@...r.kernel.org,
	Doug Anderson <dianders@...omium.org>
Subject: Re: [PATCH] regulator: core: don't require a supply when supply_name
 is specified

On Thu, Apr 04, 2013 at 03:27:47PM -0700, Andrew Bresticker wrote:

> Regulator drivers may specify regulator_desc->supply_name which
> regulator_register() will use to find the supply node for a regulator.
> If no supply was specified in the device tree or the supply has yet
> to be registered regulator_register() will fail, deferring the probe
> of the regulator.  In the case where no supply node was specified in the
> device tree, there is no supply and it is pointless to try and find one
> later, so go ahead and add the regulator without the supply.

I'd call this a broken device tree to be honest, the regulators ought to
have a supply specified.  We should complain about it.  We probably
ought to be doing this though so I'll apply.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)