linux-kernel - Re: [PATCH 2/2] regulator: max8952: Add Device Tree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130405102221.GE6597@opensource.wolfsonmicro.com>
Date:	Fri, 5 Apr 2013 11:22:21 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Tomasz Figa <t.figa@...sung.com>
Cc:	linux-kernel@...r.kernel.org, devicetree-discuss@...ts.ozlabs.org,
	linux-samsung-soc@...r.kernel.org, kyungmin.park@...sung.com,
	lrg@...com, myungjoo.ham@...sung.com, kgene.kim@...sung.com
Subject: Re: [PATCH 2/2] regulator: max8952: Add Device Tree support

On Thu, Apr 04, 2013 at 06:17:20PM +0200, Tomasz Figa wrote:

> +	if (of_property_read_u32(np, "max8952,ramp-speed", &pd->ramp_speed))
> +		dev_warn(dev, "max8952,ramp-speed property not specified, defaulting to 32mV/us\n");

Applied both, though the above warning seems a bit harsh - it seems like
assuming a worst case ramp rate ought to be totally safe and just a
minor performance issue so silently accepted.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)