linux-kernel - Re: [char-misc-next] mei: add debugfs hooks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304051415.03122.arnd@arndb.de>
Date:	Fri, 5 Apr 2013 14:15:02 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next] mei: add debugfs hooks

On Friday 05 April 2013, Tomas Winkler wrote:
> debugfs exposes device state and list of me clients and their
> properties
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>

Just one small comment:

> +#define DEBUGFS_ADD_FILE(_mei, name, parent, mode)	\
> +	debugfs_create_file(#name, mode, parent,	\
> +			_mei, &mei_dbgfs_fops_##name)


This macro seems to obfuscate more than it helps. In general, string concatenation
in macros is problematic because it means you can no longer grep for where a
symbols is being used.


	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/