linux-kernel - Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130405134635.GH31132@dhcp22.suse.cz>
Date:	Fri, 5 Apr 2013 15:46:35 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Li Zefan <lizefan@...wei.com>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>, Tejun Heo <tj@...nel.org>,
	Glauber Costa <glommer@...allels.com>,
	Johannes Weiner <hannes@...xchg.org>
Subject: Re: [RFC][PATCH 2/7] memcg: don't use mem_cgroup_get() when creating
 a kmemcg cache

On Fri 05-04-13 14:51:10, KAMEZAWA Hiroyuki wrote:
> (2013/04/03 18:12), Li Zefan wrote:
> > Use css_get()/css_put() instead of mem_cgroup_get()/mem_cgroup_put().
> > 
> > Signed-off-by: Li Zefan <lizefan@...wei.com>
> > ---
> >   mm/memcontrol.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 43ca91d..dafacb8 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -3191,7 +3191,7 @@ void memcg_release_cache(struct kmem_cache *s)
> >   	list_del(&s->memcg_params->list);
> >   	mutex_unlock(&memcg->slab_caches_mutex);
> >   
> > -	mem_cgroup_put(memcg);
> > +	css_put(&memcg->css);
> >   out:
> >   	kfree(s->memcg_params);
> >   }
> > @@ -3350,16 +3350,18 @@ static struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
> >   
> >   	mutex_lock(&memcg_cache_mutex);
> >   	new_cachep = cachep->memcg_params->memcg_caches[idx];
> > -	if (new_cachep)
> > +	if (new_cachep) {
> > +		css_put(&memcg->css);
> >   		goto out;
> > +	}
> 
> Where css_get() against this is done ?

As glauber explained in another email in this thread. It was
__memcg_create_cache_enqueue which took the reference.
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/