linux-kernel - Re: [GIT PULL] please pull infiniband.git

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1365177395.28127.148.camel@i7.infradead.org>
Date:	Fri, 05 Apr 2013 16:56:35 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Roland Dreier <roland@...nel.org>,
	Vinit Agnihotri <vinit.abhay.agnihotri@...el.com>,
	Dean Luick <dean.luick@...el.com>,
	Mike Marciniszyn <mike.marciniszyn@...el.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [GIT PULL] please pull infiniband.git

On Mon, 2013-03-25 at 09:42 -0700, Roland Dreier wrote:
> Hi Linus,
> 
> Please pull from
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus

> Vinit Agnihotri (1):
>       IB/qib: change QLogic to Intel

>  firmware/Makefile                         | 2 +-
>  firmware/{qlogic => intel}/sd7220.fw.ihex | 0

This is an ABI change, and it's wrong. Moving the firmware from one
location to another breaks drivers which look for it in one place when
it is actually in the other.

Besides, the firmware/ directory of the kernel is deprecated and very
few people actually use it. I don't think *any* distributions do
anything other than ignore its contents, or have done for some years.
Any changes need to be made in the separate linux-firmware repository.
I don't recall seeing this change being submitted there, and if it *was*
it would have been rejected on the basis that it breaks old kernels.
Unless we *duplicate* the file in both qlogic/ and intel/ directories,
but that's just silly.

We already have a *bunch* of other firmwares in the qlogic/ directory
which nobody seems interested in moving. There is no point in this
marketing-driven revisionism; please leave this one where it is too.

Please revert this part of commit e2eed58b4 before 3.9. Thanks.

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6171 bytes)