linux-kernel - Re: [PATCH v3 00/22] x86, ACPI, numa: Parse numa info early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9825274.7u1gJKhUg4@skinner.arch.suse.de>
Date:	Fri, 05 Apr 2013 18:36:25 +0200
From:	Thomas Renninger <trenn@...e.de>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tejun Heo <tj@...nel.org>, Tang Chen <tangchen@...fujitsu.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 00/22] x86, ACPI, numa: Parse numa info early

On Thursday, April 04, 2013 08:09:46 PM Yinghai Lu wrote:
...
> can you try
> 
> git checkout -b for-x86-mm origin/for-x86-mm

That worked out much better :)

I see these changes in e820 table, the first part is probably unrelated:

BIOS-e820: [mem 0x0000000000000000-0x000000000009bbff] usable
...
BIOS-e820: [mem 0x0000000000100000-0x00000000ba294fff] usable

modified: [mem 0x0000000000000000-0x0000000000000fff] reserved
modified: [mem 0x0000000000001000-0x000000000009bbff] usable
modified: [mem 0x0000000000100000-0x00000000ba27bfff] usable
...
modified: [mem 0x00000000ba27c000-0x00000000ba2947fc] ACPI data
modified: [mem 0x00000000ba2947fd-0x00000000ba294fff] usable

And the ACPI data section where the modified tables are placed
seem to get correctly inserted at:
0x00000000ba27c000-0x00000000ba2947fc

-> 0x187FC == 100,348 bytes
DSDT and FACP (better known as FADT) I passed have a size
of (see dmesg parts below):
0x18709 + 0xF4 bytes = 100,349 bytes.

Ah wait the 0xba2947fc is inclusive, so it should exactly fit.

I then see:
DSDT ACPI table found in initrd [0x378f5208-0x3790d910]
FACP ACPI table found in initrd [0x3790d9a0-0x3790da93]
ACPI: RSDP 00000000000f0410 00024 (v02  INTEL)
ACPI: XSDT 00000000bdf24d98 0008C (v01  INTEL   ROMLEY 06222004 INTL 20090903)
ACPI: Override [FACP-  ROMLEY], this is unsafe: tainting kernel
Disabling lock debugging due to kernel taint
ACPI: FACP 00000000bdf24a98 Physical table override, new table: ffffffffff4af709
ACPI: FACP 00000000ba294709 000F4 (v04  INTEL   ROMLEY 06222004 INTL 20121220)
ACPI BIOS Bug: Warning: Invalid length for FADT/Pm1aControlBlock: 32, using default 16 (20130117/tbfadt-649)
ACPI: Override [DSDT-  ROMLEY], this is unsafe: tainting kernel
ACPI: DSDT 00000000bdf09018 Physical table override, new table: ffffffffff4af000
ACPI: DSDT 00000000ba27c000 18709 (v02  INTEL   ROMLEY 00000021 INTL 20121220)

Later I see my debug string added to the DSDT when the
PCI Routing Table (_PRT) is processed:
[    9.505419] [ACPI Debug]  String [0x0A] "XXXXXXXXXX"

And taking the FADT from /sys/firmware/acpi/tables/FACP:
my:
PM Profile : 04 [Enterprise Server]
changed (as expected) to:
PM Profile : 02 [Mobile]

>From acpi overriding parts:
Tested-by: Thomas Renninger <trenn@...e.de>

I also went through the override related patches and from
what I can judge (certainly not the early memory, flat 32 bit memory you call it?
specific parts), they look fine.

Nice work!

      Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/