| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130405164123.GQ17363@zurbaran> Date: Fri, 5 Apr 2013 18:41:23 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Jiri Slaby <jslaby@...e.cz> Cc: jirislaby@...il.com, linux-kernel@...r.kernel.org Subject: Re: [PATCH] MFD: rtsx_pcr, fix probe fail path Hi Jiry, On Thu, Apr 04, 2013 at 09:34:11PM +0200, Jiri Slaby wrote: > When rtsx_pci_acquire_irq fails in rtsx_pci_probe, we forget to > disable an MSI (if we enabled it). This results in this warning on the > next attempt to load the module: > WARNING: at drivers/pci/msi.c:834 pci_enable_msi_block+0x2a4/0x2b0() > Hardware name: HP EliteBook 840 G1 > Modules linked in: rtsx_pci(+) ... > Pid: 4056, comm: modprobe Tainted: G I 3.8.0-9405-gd895cb1-1-vanilla #1 > Call Trace: > [<ffffffff81045c6a>] warn_slowpath_common+0x7a/0xc0 > [<ffffffff81045cc5>] warn_slowpath_null+0x15/0x20 > [<ffffffff81302544>] pci_enable_msi_block+0x2a4/0x2b0 > [<ffffffffa05e335a>] rtsx_pci_probe+0x55a/0x720 [rtsx_pci] > ... > > So properly disable MSI in that case. > > Signed-off-by: Jiri Slaby <jslaby@...e.cz> > --- > drivers/mfd/rtsx_pcr.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) Applied to mfd-next, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists