linux-kernel - Re: [PATCH v2] RAPL (Running Average Power Limit) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130405210605.GA18505@kroah.com>
Date:	Fri, 5 Apr 2013 14:06:05 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Platform Driver <platform-driver-x86@...r.kernel.org>,
	Matthew Garrett <matthew.garrett@...ula.com>,
	Zhang Rui <rui.zhang@...el.com>,
	Rafael Wysocki <rafael.j.wysocki@...el.com>,
	Len Brown <len.brown@...el.com>,
	Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Joe Perches <joe@...ches.com>,
	Randy Dunlap <rdunlap@...radead.org>,
	Paul Bolle <pebolle@...cali.nl>
Subject: Re: [PATCH v2] RAPL (Running Average Power Limit) driver

On Fri, Apr 05, 2013 at 02:02:03PM -0700, Jacob Pan wrote:
> Changes since V2:
> 	- use 'struct device' instead of raw kobject to represent
> 	  RAPL domains
> 	- changed eventfd control interface to use event string
> 	  instead of passing file descriptors that cannot be
> 	  authenticated in sysfs directory
> 	- clean ups based on v1 reviews
> 		- use kcalloc for arrays
> 		- drop dependencies on X86
> 		- misc cleanups

Please no, split this up into at least 2 patches, the first being the
"standard" thermal driver, and the rest for the "custom" extensions you
are proposing.

That way the first can get accepted easily, and into 3.10 (hopefully),
so people can use it and not stall everything as we continue to iterate
over the "custom" things.

As is, this driver isn't acceptable, sorry.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/