linux-kernel - Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130405220303.GA31802@kroah.com>
Date:	Fri, 5 Apr 2013 15:03:03 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	linux-kernel@...r.kernel.org, Bill Pemberton <wfp5p@...ginia.edu>,
	Joe Perches <joe@...ches.com>,
	Jonathan Cameron <jic23@....ac.uk>,
	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH] staging/adt7316 Fix some 'interesting' string operations

On Thu, Apr 04, 2013 at 02:37:24PM -0700, Luck, Tony wrote:
> Calling memcmp() to check the value of the first byte in a string is overkill.
> Just use buf[0] == '1' or buf[0] != '1' as appropriate.
> 
> Signed-off-by: Tony Luck <tony.luck@...el.com>

I'll let Jonathan take this through his tree which eventually makes it
to mine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/