linux-kernel - Re: [PATCH 3/5] SOUND: hda_generic, fix uninitialized variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk3oh4kq1.wl%tiwai@suse.de>
Date:	Fri, 05 Apr 2013 07:20:22 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH 3/5] SOUND: hda_generic, fix uninitialized variable

At Thu,  4 Apr 2013 22:32:10 +0200,
Jiri Slaby wrote:
> 
> changed is not initialized in path_power_down_sync, but it is expected
> to be false in case no change happened in the loop. So set it to
> false.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>

Thanks, applied.


Takashi

> ---
>  sound/pci/hda/hda_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c
> index f0a422f..8299e40 100644
> --- a/sound/pci/hda/hda_generic.c
> +++ b/sound/pci/hda/hda_generic.c
> @@ -751,7 +751,7 @@ EXPORT_SYMBOL_HDA(snd_hda_activate_path);
>  static void path_power_down_sync(struct hda_codec *codec, struct nid_path *path)
>  {
>  	struct hda_gen_spec *spec = codec->spec;
> -	bool changed;
> +	bool changed = false;
>  	int i;
>  
>  	if (!spec->power_down_unused || path->active)
> -- 
> 1.8.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/