linux-kernel - Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Apr 2013 22:45:42 +0800
From:	Jiang Liu <liuj97@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Jiang Liu <jiang.liu@...wei.com>,
	David Rientjes <rientjes@...gle.com>,
	Wen Congyang <wency@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, Minchan Kim <minchan@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	David Howells <dhowells@...hat.com>,
	Mark Salter <msalter@...hat.com>,
	Jianguo Wu <wujianguo@...wei.com>, linux-mm@...ck.org,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Tang Chen <tangchen@...fujitsu.com>,
	Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v4, part3 08/15] mm: fix some trivial typos in comments

On 04/06/2013 10:36 PM, Sergei Shtylyov wrote:
> Hello.
> 
> On 06-04-2013 17:55, Jiang Liu wrote:
> 
>> Fix some trivial typos in comments.
> 
>> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
>> Cc: Wen Congyang <wency@...fujitsu.com>
>> Cc: Tang Chen <tangchen@...fujitsu.com>
>> Cc: Jiang Liu <jiang.liu@...wei.com>
>> Cc: Yasuaki Ishimatsu <isimatu.yasuaki@...fujitsu.com>
>> Cc: Mel Gorman <mgorman@...e.de>
>> Cc: Minchan Kim <minchan@...nel.org>
>> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
>> Cc: linux-mm@...ck.org
>> Cc: linux-kernel@...r.kernel.org
> [...]
> 
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index 57decb2..a5b8fde 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -309,7 +309,7 @@ static int __meminit move_pfn_range_left(struct zone *z1, struct zone *z2,
>>       /* can't move pfns which are higher than @z2 */
>>       if (end_pfn > zone_end_pfn(z2))
>>           goto out_fail;
>> -    /* the move out part mast at the left most of @z2 */
>> +    /* the move out part must at the left most of @z2 */
> 
>    Maybe "must be"?
Good catch!

> 
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 6bd697c..c3c3eda 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -2863,7 +2863,7 @@ EXPORT_SYMBOL(free_pages_exact);
>>    * nr_free_zone_pages() counts the number of counts pages which are beyond the
>>    * high watermark within all zones at or below a given zone index.  For each
>>    * zone, the number of pages is calculated as:
>> - *     present_pages - high_pages
>> + *     managed_pages - high_pages
> 
>    I'm not sure it's that trivial.
We just changes the comments to follow the code, so mark it as "trivial".

Regards!
Gerry

> 
> WBR, Sergei
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/