linux-kernel - Re: [ 14/56] mwifiex: cancel cmd timer and free curr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 06 Apr 2013 20:55:55 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Marco Cesarano <marco@...vell.com>,
	Bing Zhao <bzhao@...vell.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [ 14/56] mwifiex: cancel cmd timer and free curr_cmd in
 shutdown process

On Tue, 2013-04-02 at 15:49 -0700, Greg Kroah-Hartman wrote:
> 3.0-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Bing Zhao <bzhao@...vell.com>
> 
> commit 084c7189acb3f969c855536166042e27f5dd703f upstream.
> 
> curr_cmd points to the command that is in processing or waiting
> for its command response from firmware. If the function shutdown
> happens to occur at this time we should cancel the cmd timer and
> put the command back to free queue.
> 
> Tested-by: Marco Cesarano <marco@...vell.com>
> Signed-off-by: Bing Zhao <bzhao@...vell.com>
> Signed-off-by: John W. Linville <linville@...driver.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

This also had:

    Cc: <stable@...r.kernel.org> # 3.8

so I wonder whether this is good/bad/indifferent for 3.0.y.

Ben.

> ---
>  drivers/net/wireless/mwifiex/init.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> --- a/drivers/net/wireless/mwifiex/init.c
> +++ b/drivers/net/wireless/mwifiex/init.c
> @@ -561,6 +561,14 @@ mwifiex_shutdown_drv(struct mwifiex_adap
>  		return ret;
>  	}
>  
> +	/* cancel current command */
> +	if (adapter->curr_cmd) {
> +		dev_warn(adapter->dev, "curr_cmd is still in processing\n");
> +		del_timer(&adapter->cmd_timer);
> +		mwifiex_insert_cmd_to_free_q(adapter, adapter->curr_cmd);
> +		adapter->curr_cmd = NULL;
> +	}
> +
>  	/* shut down mwifiex */
>  	dev_dbg(adapter->dev, "info: shutdown mwifiex...\n");
>  
> 


-- 
Ben Hutchings
Power corrupts.  Absolute power is kind of neat.
                           - John Lehman, Secretary of the US Navy 1981-1987

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)