linux-kernel - Re: [PATCH 1/8] staging: android: binder: replace explicit size types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130406060010.GA11127@kroah.com>
Date:	Fri, 5 Apr 2013 23:00:10 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Arve Hjønnevåg <arve@...roid.com>
Cc:	Serban Constantinescu <serban.constantinescu@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Android Kernel Team <kernel-team@...roid.com>,
	John Stultz <john.stultz@...aro.org>,
	Dave Butcher <Dave.Butcher@....com>
Subject: Re: [PATCH 1/8] staging: android: binder: replace explicit size types

On Fri, Apr 05, 2013 at 04:17:47PM -0700, Arve Hjønnevåg wrote:
> On Thu, Apr 4, 2013 at 5:32 AM, Serban Constantinescu
> <serban.constantinescu@....com> wrote:
> >
> > Since the binder driver uses both uint32_t and unsigned int any further
> > kernel changes will be difficult to read. This patch fixes the inconsistent
> > types usage.
> >
> 
> Would it make more sense to only change the types that need to be
> larger on a 64 bit system?

I agree.  You are also changing the type from explicit to "unexplicit",
the exact opposite from what I would be expecting to see here.  Why?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/