[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20130406070450.GC4501@dhcp22.suse.cz>
Date: Sat, 6 Apr 2013 09:04:50 +0200
From: Michal Hocko <mhocko@...e.cz>
To: KOSAKI Motohiro <kosaki.motohiro@...il.com>
Cc: Naoya Horiguchi <n-horiguchi@...jp.nec.com>, linux-mm@...ck.org,
Andrew Morton <akpm@...ux-foundation.org>,
Mel Gorman <mel@....ul.ie>, Hugh Dickins <hughd@...gle.com>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
Andi Kleen <andi@...stfloor.org>,
Hillf Danton <dhillf@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/10] mbind: add hugepage migration code to mbind()
On Fri 05-04-13 18:23:07, KOSAKI Motohiro wrote:
> >> - if (!new_hpage)
> >> + /*
> >> + * Getting a new hugepage with alloc_huge_page() (which can happen
> >> + * when migration is caused by mbind()) can return ERR_PTR value,
> >> + * so we need take care of the case here.
> >> + */
> >> + if (!new_hpage || IS_ERR_VALUE(new_hpage))
> >> return -ENOMEM;
> >
> > Please no. get_new_page returns NULL or a page. You are hooking a wrong
> > callback here. The error value doesn't make any sense here. IMO you
> > should just wrap alloc_huge_page by something that returns NULL or page.
>
> I suggest just opposite way. new_vma_page() always return ENOMEM, ENOSPC etc instad
> of NULL. and caller propegate it to userland.
> I guess userland want to distingush why mbind was failed.
Sure, and I wasn't suggesting to change alloc_huge_page. I was just
pointing out that new_page_t used to return page or NULL and hugetlb
unmap_and_move shouldn't be any different in that direction so using
alloc_huge_page is not a good fit here.
> Anyway, If new_vma_page() have a change to return both NULL and
> -ENOMEM. That's a bug.
--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists