linux-kernel - Re: [PATCH 2/2] hfsplus: add printk to log allocation failure in hfs_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365372019.8922.17.camel@joe-AO722>
Date:	Sun, 07 Apr 2013 15:00:19 -0700
From:	Joe Perches <joe@...ches.com>
To:	Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:	Vyacheslav Dubeyko <slava@...eyko.com>,
	Hin-Tak Leung <htl10@...rs.sourceforge.net>,
	Al Viro <viro@...iv.linux.org.uk>,
	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>,
	Christoph Hellwig <hch@....de>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH 2/2] hfsplus: add printk to log allocation failure in
 hfs_find_init()

On Mon, 2013-04-08 at 01:21 +0400, Alexey Khoroshilov wrote:
> Add printk to log allocation failure in hfs_find_init(),
> "so that there is a sign in dmesg when the error condition is triggered".
> (per Hin-Tak Leung request)

Not needed.  There already is a generic dump_stack
on all allocation failures without __GFP_NOWARN.

> diff --git a/fs/hfsplus/bfind.c b/fs/hfsplus/bfind.c
[]
> @@ -18,8 +18,10 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)

> +	if (!ptr) {
> +		printk(KERN_ERR "hfs: allocation failed in hfs_find_init()\n");
>  		return -ENOMEM;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/