| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1365373938-25993-1-git-send-email-richard@nod.at> Date: Mon, 8 Apr 2013 00:32:17 +0200 From: Richard Weinberger <richard@....at> To: matt.fleming@...el.com Cc: cbouatmailru@...il.com, ccross@...roid.com, keescook@...omium.org, tony.luck@...el.com, linux-efi@...r.kernel.org, linux-kernel@...r.kernel.org, matthew.garrett@...ula.com, Richard Weinberger <richard@....at> Subject: [PATCH v2 1/2] efivars: Check max_size only if it is non-zero. Some EFI implementations return always a MaximumVariableSize of 0, check against max_size only if it is non-zero. Signed-off-by: Richard Weinberger <richard@....at> --- drivers/firmware/efivars.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/firmware/efivars.c b/drivers/firmware/efivars.c index 7acafb8..60c9899 100644 --- a/drivers/firmware/efivars.c +++ b/drivers/firmware/efivars.c @@ -449,7 +449,11 @@ check_var_size_locked(struct efivars *efivars, u32 attributes, if (status != EFI_SUCCESS) return status; - if (!storage_size || size > remaining_size || size > max_size || + if (!max_size && remaining_size > size) + printk_once(KERN_ERR FW_BUG "Broken EFI implementation is returning MaxVariableSize=0\n"); + + if (!storage_size || size > remaining_size || + (max_size && size > max_size) || (remaining_size - size) < (storage_size / 2)) return EFI_OUT_OF_RESOURCES; -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists