linux-kernel - RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1AE640813FDE7649BE1B193DEA596E88015CDB97@SHSMSX101.ccr.corp.intel.com>
Date:	Sun, 7 Apr 2013 07:00:34 +0000
From:	"Zheng, Lv" <lv.zheng@...el.com>
To:	"Zheng, Lv" <lv.zheng@...el.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Paul Bolle <pebolle@...cali.nl>
CC:	Len Brown <lenb@...nel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Moore, Robert" <robert.moore@...el.com>
Subject: RE: [PATCH] ACPI: remove "config ACPI_DEBUG_FUNC_TRACE"

> > > Kconfig symbol ACPI_DEBUG_FUNC_TRACE was only used (through its
> > > corresponding macro) in drivers/acpi/acpica/acmacros.h. That macro
> > > was removed from that header in v3.8, with commit
> > > 86ff0e508f88eda6e479a897476026055831d2d8 ("ACPICA: Fix unmerged
> > > acmacros.h divergences."). That commit did not explain why that
> > > macro was removed. But it seems that ACPI_DEBUG_FUNC_TRACE can
> now
> > > be removed too, as it is unused.
> >
> > Lv, can you please comment here?
> 
> Sorry for the delayed reply.
> 
> The commit should have done something that already have been done in the
> ACPICA.
> I'll take a look at this.

The original commit deleted CONFIG_ACPI_DEBUG_FUNC_TRACE from acmacros.h as it is in the __wrong__ place.
CONFIG_xxx is linux specific codes thus should appear in OSL layer - aclinux.h.
ACPICA specific codes should only use selective definitions in #ifdef ACPI_xxx style and such codes should be merged into ACPICA rather than being merged into Linux ACPI.

Now we have two choices:
Re-implement it in the aclinux.h using "ACPI_DEBUG_OUTPUT" defined/undefined or delete this kernel configuration item temporarily.

Thanks and best regards
-Lv