linux-kernel - Re: [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 7 Apr 2013 03:13:57 -0700
From:	Michel Lespinasse <walken@...gle.com>
To:	k80c <k80ck80c@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rik van Riel <riel@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Ingo Molnar <mingo@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] mmap.c: find_vma: eliminate initial if(mm) check

On Sun, Apr 7, 2013 at 2:18 AM, k80c <k80ck80c@...il.com> wrote:
> As per commit 841e31e5cc6219d62054788faa289b6ed682d068,
> we dont really need this if(mm) check anymore.
>
> A WARN_ON_ONCE was added just for safety, but there have been no bug
> reports about this so far.
>
> Removing this if(mm) check.
>
> Signed-off-by: k80c <k80ck80c@...il.com>
> ---
>  mm/mmap.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/mm/mmap.c b/mm/mmap.c
> index 0db0de1..b2c363f 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -1935,9 +1935,6 @@ struct vm_area_struct *find_vma(struct mm_struct *mm, unsigned long addr)
>  {
>         struct vm_area_struct *vma = NULL;
>
> -       if (WARN_ON_ONCE(!mm))          /* Remove this in linux-3.6 */
> -               return NULL;
> -
>         /* Check the cache first. */
>         /* (Cache hit rate is typically around 35%.) */
>         vma = ACCESS_ONCE(mm->mmap_cache);

Looks good to me.

Reviewed-by: Michel Lespinasse <walken@...gle.com>

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/