linux-kernel - Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365333863.7207.14.camel@mattotaupa>
Date:	Sun, 07 Apr 2013 13:24:23 +0200
From:	Paul Menzel <paulepanter@...rs.sourceforge.net>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	airlied@...ux.ie, bskeggs@...hat.com, airlied@...hat.com,
	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drivers/gpu/drm/nouveau: remove erroneous semicolon

Dear Chen,


Am Mittwoch, den 27.03.2013, 15:23 +0800 schrieb Chen Gang:
>   need remove semicolon, or always return true.

do you know if this cause any problems? Did you find this reading the
code or by using some tools?

> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nv50_display.c b/drivers/gpu/drm/nouveau/nv50_display.c
> index 7f0e6c3..1ddc03e 100644
> --- a/drivers/gpu/drm/nouveau/nv50_display.c
> +++ b/drivers/gpu/drm/nouveau/nv50_display.c
> @@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
>  {
>  	struct nv50_display_flip *flip = data;
>  	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
> -					      flip->chan->data);
> +					      flip->chan->data)
>  		return true;
>  	usleep_range(1, 2);
>  	return false;

Acked-by: Paul Menzel <paulepanter@...rs.sourceforge.net>


Thanks,

Paul

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)