linux-kernel - Re: [RFC PATCH] wfcqueue: implement __wfcq_enqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130408021750.GA7306@dcvr.yhbt.net>
Date:	Mon, 8 Apr 2013 02:17:50 +0000
From:	Eric Wong <normalperson@...t.net>
To:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc:	linux-kernel@...r.kernel.org,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Lai Jiangshan <laijs@...fujitsu.com>
Subject: Re: [RFC PATCH] wfcqueue: implement __wfcq_enqueue_head() (v3)

Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
> Changes since v2:
> * Only issue cmpxchg() if queue was empty.
> * Add missing memory barrier.

Thanks!

There's a slight drop in performance either from the barrier or larger
code, but I'm not worried (it was around 9-10s before wfcqueue).

$ time ./eponeshotmt -c 1000000 -w 4 -t 4 -f 10
real    0m 5.83s
user    0m 1.35s
sys     0m 21.95s

I also ran v2 on Davide Libenzi's totalmess epoll stresser for a few
hours yesterday without failures.  Running totalmess right now on v3,
so far so good :)

Tested-by: Eric Wong <normalperson@...t.net>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/