linux-kernel - Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51629686.7030708@linutronix.de>
Date:	Mon, 08 Apr 2013 12:05:58 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Lai Jiangshan <laijs@...fujitsu.com>
CC:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org, tglx@...utronix.de
Subject: Re: [PATCH 1/3] kernel/srcu: merge common code into a macro

On 04/05/2013 09:21 AM, Lai Jiangshan wrote:
> Hi, Sebastian

Hi Lai,

> The patch hurts readability.
> The original code are simple enough, merging them as one macro
> gives us no benefit.

Except when you need to adjust the macro and you have to touch both of
them instead just one. But I don't have strong feelings for that one.

> Thanks
> Lai.

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/