linux-kernel - Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304081243.31940@pali>
Date:	Mon, 8 Apr 2013 12:43:31 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
Cc:	Anton Vorontsov <cbou@...l.ru>, linux-kernel@...r.kernel.org,
	Keerthy <j-keerthy@...com>, Kyle Manna <kyle@...emanna.com>
Subject: Re: [PATCH 1/2] mfd: twl4030-madc: Add support for raw value in twl4030_madc_conversion

On Thursday 04 April 2013 11:38:47 Samuel Ortiz wrote:
> Hi Pali,
> 
> On Sat, Mar 02, 2013 at 11:23:05PM +0100, Pali Rohár wrote:
> > On Friday 15 February 2013 23:56:49 Pali Rohár wrote:
> > > Driver twl4030-madc has hardcoded channel types (10 -
> > > battery current, 1 - battery temperature) and also
> > > conversation data in variable twl4030_divider_ratios.
> > > These hardcoded channels are incorrect for Nokia RX-51
> > > board (where is channel 0 - battery temperature).
> > > 
> > > For Nokia RX-51 there is rx51_battery power_supply driver
> > > which reporting battery information via
> > > twl4030_madc_conversion. But this driver needs raw values
> > > (not converted via some hardcoded functions). So this
> > > patch adding new parameter "raw" to struct
> > > twl4030_madc_request which tell twl4030-madc driver to
> > > not convert values, but rather return raw.
> > > 
> > > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > > ---
> > > 
> > >  drivers/mfd/twl4030-madc.c       |   14 ++++++++++----
> > >  include/linux/i2c/twl4030-madc.h |    2 ++
> > >  2 files changed, 12 insertions(+), 4 deletions(-)
> > 
> > Hello, can somebody review this twl4030-madc patch?
> 
> I'll look at all my pending MFD patches starting from
> tomorrow.
> 
> Cheers,
> Samuel.

Hi Samuel, did you look at this patch?

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)