linux-kernel - Re: [PATCH] perf: Enable function tracing for perf core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365435422.25498.7.camel@gandalf.local.home>
Date:	Mon, 08 Apr 2013 11:37:02 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	a.p.zijlstra@...llo.nl, mingo@...nel.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] perf: Enable function tracing for perf core

On Thu, 2013-03-28 at 08:45 -0700, Andi Kleen wrote:
> Andi Kleen <andi@...stfloor.org> writes:
> 
> > From: Andi Kleen <ak@...ux.intel.com>
> >
> > According to Steven R. there is no reason left to not support
> > function tracing for the perf core. This makes it easier to debug
> > perf.
> >
> > Don't remove -pg for the x86 and generic perf core.
> 
> Ping! patch is missing review.
> 

This needs an acked-by from either Peter or Frederic.

-- Steve

> 
> >
> > Cc: rostedt@...dmis.org
> > Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> > ---
> >  arch/x86/kernel/cpu/Makefile |    1 -
> >  kernel/events/Makefile       |    4 ----
> >  2 files changed, 0 insertions(+), 5 deletions(-)
> >
> > diff --git a/arch/x86/kernel/cpu/Makefile b/arch/x86/kernel/cpu/Makefile
> > index a0e067d..8eb5d28 100644
> > --- a/arch/x86/kernel/cpu/Makefile
> > +++ b/arch/x86/kernel/cpu/Makefile
> > @@ -5,7 +5,6 @@
> >  # Don't trace early stages of a secondary CPU boot
> >  ifdef CONFIG_FUNCTION_TRACER
> >  CFLAGS_REMOVE_common.o = -pg
> > -CFLAGS_REMOVE_perf_event.o = -pg
> >  endif
> >  
> >  # Make sure load_percpu_segment has no stackprotector
> > diff --git a/kernel/events/Makefile b/kernel/events/Makefile
> > index 103f5d1..a630994 100644
> > --- a/kernel/events/Makefile
> > +++ b/kernel/events/Makefile
> > @@ -1,7 +1,3 @@
> > -ifdef CONFIG_FUNCTION_TRACER
> > -CFLAGS_REMOVE_core.o = -pg
> > -endif
> > -
> >  obj-y := core.o ring_buffer.o callchain.o
> >  
> >  obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/