linux-kernel - Re: [PATCH] F2FS: Fix the logic of IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1365401875.4353.44.camel@kjgkr>
Date:	Mon, 08 Apr 2013 15:17:55 +0900
From:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
To:	Zhihui Zhang <zzhsuny@...il.com>
Cc:	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] F2FS: Fix the logic of IS_DNODE()

Hi,

2013-04-07 (일), 12:57 -0400, Zhihui Zhang:
> Signed-off-by: Zhihui Zhang <zzhsuny@...il.com>
> ---
>  fs/f2fs/node.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
> index afdb130..2be47b2 100644
> --- a/fs/f2fs/node.h
> +++ b/fs/f2fs/node.h
> @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
>  		return false;
>  	if (ofs >= 6 + 2 * NIDS_PER_BLOCK) {
>  		ofs -= 6 + 2 * NIDS_PER_BLOCK;
> -		if ((long int)ofs % (NIDS_PER_BLOCK + 1))
> +		if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

>  			return false;
>  	}
>  	return true;

-- 
Jaegeuk Kim
Samsung


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)