linux-kernel - Re: [PATCH] Convert compat_sys_sysinfo to COMPAT_SYSCALL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130408143554.3d23a6d96bd880d46c201e8a@linux-foundation.org>
Date:	Mon, 8 Apr 2013 14:35:54 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Guenter Roeck <linux@...ck-us.net>,
	Al Viro <viro@...iv.linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Convert compat_sys_sysinfo to COMPAT_SYSCALL_DEFINE

On Mon, 8 Apr 2013 14:56:16 +1000 Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> --- a/kernel/timer.c
> +++ b/kernel/timer.c
> @@ -1661,8 +1661,7 @@ struct compat_sysinfo {
>  	char _f[20-2*sizeof(u32)-sizeof(int)];
>  };
>  
> -asmlinkage long
> -compat_sys_sysinfo(struct compat_sysinfo __user *info)
> +COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)

wtflol.

akpm3:/usr/src/25> grep SYSCALL kernel/timer.c 
SYSCALL_DEFINE1(alarm, unsigned int, seconds)
SYSCALL_DEFINE0(getpid)
SYSCALL_DEFINE0(getppid)
SYSCALL_DEFINE0(getuid)
SYSCALL_DEFINE0(geteuid)
SYSCALL_DEFINE0(getgid)
SYSCALL_DEFINE0(getegid)
SYSCALL_DEFINE0(gettid)
SYSCALL_DEFINE1(sysinfo, struct sysinfo __user *, info)
COMPAT_SYSCALL_DEFINE1(sysinfo, struct compat_sysinfo __user *, info)

Only one of those should be in kernel/timer.c.  Who wrote this thing?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/