linux-kernel - Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365491284.2482.19.camel@slavad-ubuntu>
Date:	Tue, 09 Apr 2013 11:08:04 +0400
From:	Vyacheslav Dubeyko <slava@...eyko.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Hin-Tak Leung <htl10@...rs.sourceforge.net>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote:
> Joe Perches (2):
>   hfs/hfsplus: Convert dprint to hfs_dbg
>   hfs/hfsplus: Convert printks to pr_<level>
> 

Thank you for your efforts. It is a good work.

But I have some additional suggestions:
(1) I think that it makes sense to use no_printk() for the case when we
don't need in debug output.
(2) I think that it is really necessary to add info about file and line
number for the case of debug output.

As I know Hin Tak has some code for dynamic debugging. I think that it
is a time for publish this work also. But I suppose that we can have
opportunity to choose old-fashioned HFS debugging output or dynamic
debug by means of declaration of special macro definition for every
case. I mean constant for every case (static debug, dynamic debug, no
debug).

Thanks,
Vyacheslav Dubeyko.

>  fs/hfs/bfind.c          | 10 +++++----
>  fs/hfs/bitmap.c         |  4 ++--
>  fs/hfs/bnode.c          | 39 ++++++++++++++++++----------------
>  fs/hfs/brec.c           | 19 +++++++++--------
>  fs/hfs/btree.c          | 31 ++++++++++++++-------------
>  fs/hfs/catalog.c        | 12 ++++++-----
>  fs/hfs/dir.c            | 12 +++++------
>  fs/hfs/extent.c         | 20 ++++++++++--------
>  fs/hfs/hfs_fs.h         | 20 ++++++++++++++++--
>  fs/hfs/inode.c          |  4 ++--
>  fs/hfs/mdb.c            | 23 ++++++++++----------
>  fs/hfs/super.c          | 43 +++++++++++++++++++------------------
>  fs/hfsplus/attributes.c | 26 +++++++++++------------
>  fs/hfsplus/bfind.c      |  6 +++---
>  fs/hfsplus/bitmap.c     | 12 +++++------
>  fs/hfsplus/bnode.c      | 36 +++++++++++++++----------------
>  fs/hfsplus/brec.c       | 14 ++++++-------
>  fs/hfsplus/btree.c      | 29 +++++++++++++------------
>  fs/hfsplus/catalog.c    | 11 +++++-----
>  fs/hfsplus/dir.c        | 14 ++++++-------
>  fs/hfsplus/extents.c    | 32 ++++++++++++++--------------
>  fs/hfsplus/hfsplus_fs.h | 20 +++++++++++++++---
>  fs/hfsplus/inode.c      |  4 ++--
>  fs/hfsplus/options.c    | 22 +++++++++----------
>  fs/hfsplus/super.c      | 56 +++++++++++++++++++------------------------------
>  fs/hfsplus/wrapper.c    |  8 +++----
>  fs/hfsplus/xattr.c      | 41 ++++++++++++++++++------------------
>  27 files changed, 296 insertions(+), 272 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/