linux-kernel - Re: [PATCH V4 3/4] block: queue work on unbound wq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKohpomZFK77w-9fE_Z7WArpJspk3kp15tJ+e-5BER_oZjo9ag@mail.gmail.com>
Date:	Tue, 9 Apr 2013 15:05:16 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Amit Kucheria <amit.kucheria@...aro.org>
Cc:	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	Robin Randhawa <robin.randhawa@....com>,
	linux-rt-users@...r.kernel.org,
	Patch Tracking <patches@...aro.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Liviu Dudau <Liviu.Dudau@....com>,
	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Lists linaro-kernel <linaro-kernel@...ts.linaro.org>,
	Steve Bannister <Steve.Bannister@....com>, airlied@...hat.com,
	Arvind Chauhan <arvind.chauhan@....com>, mingo@...hat.com,
	davem@...emloft.net,
	Charles Garcia-Tobin <charles.garcia-tobin@....com>
Subject: Re: [PATCH V4 3/4] block: queue work on unbound wq

On 9 April 2013 14:48, Amit Kucheria <amit.kucheria@...aro.org> wrote:
> On Tue, Apr 9, 2013 at 1:00 PM, Viresh Kumar <viresh.kumar@...aro.org> wrote:

>> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
>> +config WQ_POWER_EFFICIENT
>> +       bool "Workqueue allocated as UNBOUND for power efficiency"
>> +       depends on PM
>
> Should default to N so that existing configs don't get prompted for a choice.

I thought defaults default is N if not present. I can add default n if
it is required.

>> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
>> +static bool wq_power_efficient = 0;
>
> 1?

It should be disabled by default even if CONFIG_WQ_POWER_EFFICIENT is
selected and so initialized it with zero.. Though i don't need to
initialize it as
default is 0.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/